From mboxrd@z Thu Jan 1 00:00:00 1970 From: Flavio Leitner Subject: Re: [PATCH net-next] net: preserve sock reference when scrubbing the skb. Date: Tue, 26 Jun 2018 09:38:05 -0300 Message-ID: <20180626123805.GK19565@plex.lan> References: <20180625155610.30802-1-fbl@redhat.com> <48e15faf-f935-0166-e1db-18f7286e7264@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Cong Wang , Linux Kernel Network Developers , Paolo Abeni , David Miller , Florian Westphal , NetFilter To: Eric Dumazet Return-path: Received: from mail-qk0-f196.google.com ([209.85.220.196]:45426 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934276AbeFZMiL (ORCPT ); Tue, 26 Jun 2018 08:38:11 -0400 Received: by mail-qk0-f196.google.com with SMTP id c198-v6so9356307qkg.12 for ; Tue, 26 Jun 2018 05:38:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <48e15faf-f935-0166-e1db-18f7286e7264@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jun 25, 2018 at 11:41:05PM -0700, Eric Dumazet wrote: > I am not sure why the patch is so complex, I would have simply > removed the skb_orphan(). All the rest is fixing netfilter to consider the namespaces before doing any actions. For instance, it would be possible to dump GID/UID of the process originating the packet in a foreign net namespace. Another example is matching if it has a socket or not. I don't think it's correct to match on a socket that is on a foreign netns. So, you're right that removing the skb_orphan() is the only thing required to fix both issues, but then what about the above examples? -- Flavio