From mboxrd@z Thu Jan 1 00:00:00 1970 From: dsahern@kernel.org Subject: [PATCH net-next] netlink: Return extack message if attribute validation fails Date: Tue, 26 Jun 2018 12:39:18 -0700 Message-ID: <20180626193918.25692-1-dsahern@kernel.org> Cc: jakub.kicinski@netronome.com, David Ahern To: netdev@vger.kernel.org Return-path: Received: from mail.kernel.org ([198.145.29.99]:46654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752192AbeFZTjL (ORCPT ); Tue, 26 Jun 2018 15:39:11 -0400 Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Have one extack message for parsing and validating. Signed-off-by: David Ahern --- lib/nlattr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/nlattr.c b/lib/nlattr.c index dfa55c873c13..e335bcafa9e4 100644 --- a/lib/nlattr.c +++ b/lib/nlattr.c @@ -253,8 +253,8 @@ int nla_parse(struct nlattr **tb, int maxtype, const struct nlattr *head, if (policy) { err = validate_nla(nla, maxtype, policy); if (err < 0) { - if (extack) - extack->bad_attr = nla; + NL_SET_ERR_MSG_ATTR(extack, nla, + "Attribute failed policy validation"); goto errout; } } -- 2.11.0