From: David Miller <davem@davemloft.net>
To: Jason@zx2c4.com
Cc: roopa@cumulusnetworks.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] fib_rules: match rules based on suppress_* properties too
Date: Wed, 27 Jun 2018 10:34:17 +0900 (KST) [thread overview]
Message-ID: <20180627.103417.614359212764375850.davem@davemloft.net> (raw)
In-Reply-To: <20180625233932.11531-1-Jason@zx2c4.com>
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Tue, 26 Jun 2018 01:39:32 +0200
> Two rules with different values of suppress_prefix or suppress_ifgroup
> are not the same. This fixes an -EEXIST when running:
>
> $ ip -4 rule add table main suppress_prefixlength 0
>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> Fixes: f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs into fib_nl2rule")
Roopa, thanks for doing all of that analysis.
I think applying this patch makes the most sense at this point,
so that it what I have done.
next prev parent reply other threads:[~2018-06-27 1:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 15:46 [net regression] "fib_rules: move common handling of newrule delrule msgs into fib_nl2rule" breaks suppress_prefixlength Jason A. Donenfeld
2018-06-23 15:59 ` [PATCH] fib_rules: match rules based on suppress_* properties too Jason A. Donenfeld
2018-06-24 2:25 ` David Miller
2018-06-25 14:58 ` Roopa Prabhu
2018-06-25 23:39 ` [PATCH v2] " Jason A. Donenfeld
2018-06-26 14:51 ` Roopa Prabhu
2018-06-27 1:34 ` David Miller [this message]
2018-06-27 4:53 ` Roopa Prabhu
2018-06-25 15:23 ` [net regression] "fib_rules: move common handling of newrule delrule msgs into fib_nl2rule" breaks suppress_prefixlength Roopa Prabhu
2018-06-25 18:36 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627.103417.614359212764375850.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jason@zx2c4.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).