From: Steffen Klassert <steffen.klassert@secunet.com>
To: Shannon Nelson <shannon.nelson@oracle.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH ipsec-next 1/1] xfrm: don't check offload_handle for nonzero
Date: Wed, 27 Jun 2018 17:49:41 +0200 [thread overview]
Message-ID: <20180627154941.xtqir64664qrssv5@gauss3.secunet.de> (raw)
In-Reply-To: <1530047950-3967-1-git-send-email-shannon.nelson@oracle.com>
On Tue, Jun 26, 2018 at 02:19:10PM -0700, Shannon Nelson wrote:
> The offload_handle should be an opaque data cookie for the driver
> to use, much like the data cookie for a timer or alarm callback.
> Thus, the XFRM stack should not be checking for non-zero, because
> the driver might use that to store an array reference, which could
> be zero, or some other zero but meaningful value.
>
> We can remove the checks for non-zero because there are plenty
> other attributes also being checked to see if there is an offload
> in place for the SA in question.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
I don't have access to my hw offload testlab currently,
so I've queued this one until I'm back from my vacation.
next prev parent reply other threads:[~2018-06-27 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 21:19 [PATCH ipsec-next 1/1] xfrm: don't check offload_handle for nonzero Shannon Nelson
2018-06-27 15:49 ` Steffen Klassert [this message]
2018-07-23 5:42 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627154941.xtqir64664qrssv5@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox