From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: net: ipw2x00: Replace NULL comparison with !priv Date: Wed, 27 Jun 2018 16:05:01 +0000 (UTC) Message-ID: <20180627160501.E369660B10@smtp.codeaurora.org> References: <20180603111136.4262-1-rvarsha016@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Stanislav Yakovlev , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire , Lukas Bulwahn , Varsha Rao To: Varsha Rao Return-path: In-Reply-To: <20180603111136.4262-1-rvarsha016@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Varsha Rao wrote: > Remove extra parentheses and replace NULL comparison with !priv, to fix > clang warning of extraneous parentheses and check patch issue. Following > coccinelle script is used to fix it. > > @disable is_null,paren@ > expression e; > statement s; > @@ > if ( > - (e==NULL) > +!e > ) > s > > Signed-off-by: Varsha Rao Patch applied to wireless-drivers-next.git, thanks. 4e5f881d430a net: ipw2x00: Replace NULL comparison with !priv -- https://patchwork.kernel.org/patch/10445241/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches