From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] l2tp: define helper for parsing struct sockaddr_pppol2tp* Date: Thu, 28 Jun 2018 16:07:10 +0900 (KST) Message-ID: <20180628.160710.1852747341470803055.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jchapman@katalix.com To: g.nault@alphalink.fr Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:46836 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933017AbeF1HHQ (ORCPT ); Thu, 28 Jun 2018 03:07:16 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Guillaume Nault Date: Tue, 26 Jun 2018 18:41:36 +0200 > 'sockaddr_len' is checked against various values when entering > pppol2tp_connect(), to verify its validity. It is used again later, to > find out which sockaddr structure was passed from user space. This > patch combines these two operations into one new function in order to > simplify pppol2tp_connect(). > > A new structure, l2tp_connect_info, is used to pass sockaddr data back > to pppol2tp_connect(), to avoid passing too many parameters to > l2tp_sockaddr_get_info(). Also, the first parameter is void* in order > to avoid casting between all sockaddr_* structures manually. > > Signed-off-by: Guillaume Nault Applied.