From: Jiri Pirko <jiri@resnulli.us>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jakub.kicinski@netronome.com,
simon.horman@netronome.com, john.hurley@netronome.com,
dsahern@gmail.com, mlxsw@mellanox.com
Subject: Re: [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw
Date: Thu, 28 Jun 2018 08:25:47 +0200 [thread overview]
Message-ID: <20180628062547.GC2413@nanopsycho> (raw)
In-Reply-To: <20180628.134826.1129904828597717313.davem@davemloft.net>
Thu, Jun 28, 2018 at 06:48:26AM CEST, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Tue, 26 Jun 2018 09:59:51 +0200
>
>> For the TC clsact offload these days, some of HW drivers need
>> to hold a magic ball. The reason is, with the first inserted rule inside
>> HW they need to guess what fields will be used for the matching. If
>> later on this guess proves to be wrong and user adds a filter with a
>> different field to match, there's a problem. Mlxsw resolves it now with
>> couple of patterns. Those try to cover as many match fields as possible.
>> This aproach is far from optimal, both performance-wise and scale-wise.
>> Also, there is a combination of filters that in certain order won't
>> succeed.
>>
>> Most of the time, when user inserts filters in chain, he knows right away
>> how the filters are going to look like - what type and option will they
>> have. For example, he knows that he will only insert filters of type
>> flower matching destination IP address. He can specify a template that
>> would cover all the filters in the chain.
>>
>> This patchset is providing the possibility to user to provide such
>> template to kernel and propagate it all the way down to device
>> drivers.
>
>This series doesn't apply cleanly to net-next, and also there seems to still
>be some discussion about how the iproute2 command line should look.
Will re-spin. Thanks.
>
>Thanks.
next prev parent reply other threads:[~2018-06-28 6:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 7:59 [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw Jiri Pirko
2018-06-26 7:59 ` [patch net-next v2 1/9] net: sched: push ops lookup bits into tcf_proto_lookup_ops() Jiri Pirko
2018-06-26 7:59 ` [patch net-next v2 2/9] net: sched: introduce chain templates Jiri Pirko
2018-06-26 7:59 ` [patch net-next v2 3/9] net: sched: cls_flower: move key/mask dumping into a separate function Jiri Pirko
2018-06-26 7:59 ` [patch net-next v2 4/9] net: sched: cls_flower: change fl_init_dissector to accept mask and dissector Jiri Pirko
2018-06-26 7:59 ` [patch net-next v2 5/9] net: sched: cls_flower: implement chain templates Jiri Pirko
2018-06-26 7:59 ` [patch net-next v2 6/9] net: sched: cls_flower: propagate chain teplate creation and destruction to drivers Jiri Pirko
2018-06-26 7:59 ` [patch net-next v2 7/9] mlxsw: spectrum: Implement chain template hinting Jiri Pirko
2018-06-26 10:20 ` Ido Schimmel
2018-06-26 7:59 ` [patch net-next v2 8/9] selftests: forwarding: move shblock tc support check to a separate helper Jiri Pirko
2018-06-26 8:00 ` [patch net-next v2 9/9] selftests: forwarding: add tests for TC chain templates Jiri Pirko
2018-06-27 0:04 ` [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw Cong Wang
2018-06-27 6:05 ` Jiri Pirko
2018-06-27 6:34 ` Samudrala, Sridhar
2018-06-27 7:03 ` Jiri Pirko
2018-06-28 4:48 ` David Miller
2018-06-28 6:25 ` Jiri Pirko [this message]
2018-06-28 17:38 ` Cong Wang
2018-06-28 13:13 ` Jamal Hadi Salim
2018-06-28 13:22 ` Jiri Pirko
2018-06-28 13:54 ` Jamal Hadi Salim
2018-06-28 14:17 ` Jiri Pirko
-- strict thread matches above, loose matches on Subject: below --
2018-06-28 13:08 Jiri Pirko
2018-06-28 13:24 ` Jiri Pirko
2018-06-28 14:18 ` David Ahern
2018-06-28 14:29 ` Jiri Pirko
2018-06-28 15:10 ` David Ahern
2018-06-28 15:37 ` Jiri Pirko
2018-06-28 15:50 ` David Ahern
2018-06-28 16:08 ` Jiri Pirko
2018-06-28 22:25 ` Cong Wang
2018-06-29 8:39 ` Jiri Pirko
2018-06-29 12:12 ` Jamal Hadi Salim
2018-06-29 12:48 ` Jiri Pirko
2018-06-29 12:54 ` David Ahern
2018-06-29 13:05 ` Jiri Pirko
2018-06-29 17:06 ` Samudrala, Sridhar
2018-06-29 22:18 ` Cong Wang
2018-06-30 10:12 ` Jiri Pirko
2018-07-02 19:33 ` Cong Wang
2018-06-29 13:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628062547.GC2413@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=john.hurley@netronome.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).