From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw Date: Thu, 28 Jun 2018 08:25:47 +0200 Message-ID: <20180628062547.GC2413@nanopsycho> References: <20180626080000.12964-1-jiri@resnulli.us> <20180628.134826.1129904828597717313.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jakub.kicinski@netronome.com, simon.horman@netronome.com, john.hurley@netronome.com, dsahern@gmail.com, mlxsw@mellanox.com To: David Miller Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:37899 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753525AbeF1G1R (ORCPT ); Thu, 28 Jun 2018 02:27:17 -0400 Received: by mail-wm0-f65.google.com with SMTP id 69-v6so7655277wmf.3 for ; Wed, 27 Jun 2018 23:27:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180628.134826.1129904828597717313.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Jun 28, 2018 at 06:48:26AM CEST, davem@davemloft.net wrote: >From: Jiri Pirko >Date: Tue, 26 Jun 2018 09:59:51 +0200 > >> For the TC clsact offload these days, some of HW drivers need >> to hold a magic ball. The reason is, with the first inserted rule inside >> HW they need to guess what fields will be used for the matching. If >> later on this guess proves to be wrong and user adds a filter with a >> different field to match, there's a problem. Mlxsw resolves it now with >> couple of patterns. Those try to cover as many match fields as possible. >> This aproach is far from optimal, both performance-wise and scale-wise. >> Also, there is a combination of filters that in certain order won't >> succeed. >> >> Most of the time, when user inserts filters in chain, he knows right away >> how the filters are going to look like - what type and option will they >> have. For example, he knows that he will only insert filters of type >> flower matching destination IP address. He can specify a template that >> would cover all the filters in the chain. >> >> This patchset is providing the possibility to user to provide such >> template to kernel and propagate it all the way down to device >> drivers. > >This series doesn't apply cleanly to net-next, and also there seems to still >be some discussion about how the iproute2 command line should look. Will re-spin. Thanks. > >Thanks.