From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v7 03/11] net: pch_gbe: Probe PHY ID & initialize only once Date: Thu, 28 Jun 2018 09:47:48 +0200 Message-ID: <20180628074748.GC15034@lunn.ch> References: <20180627000612.27263-1-paul.burton@mips.com> <20180627000612.27263-4-paul.burton@mips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, "David S . Miller" To: Paul Burton Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:45347 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964991AbeF1Hrv (ORCPT ); Thu, 28 Jun 2018 03:47:51 -0400 Content-Disposition: inline In-Reply-To: <20180627000612.27263-4-paul.burton@mips.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jun 26, 2018 at 05:06:04PM -0700, Paul Burton wrote: > The pch_gbe driver currently probes for the PHY ID & configures the PHY > every time the MAC is reset, even though we know that the PHY won't have > changed since the last MAC reset [1]. > > This patch moves the PHY probe to instead happen only once when the > driver is probed, saving time & moving us closer to the behavior we'll > have with phylib. > > [1] Please, someone patent PHY hotplugging & rigorously enforce said > patent such that nobody can do it. At least not with an EG20T MAC. I suppose one additional point here is that with the change to phylib, and the removal of the code to disable hibernation, the phyid becomes irrelevant to the MAC driver. So the important change here is moving phy initialization to the probe. Andrew