From: Andrew Lunn <andrew@lunn.ch>
To: Dan Murphy <dmurphy@ti.com>
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: phy: DP83TC811: Add INT_STAT3
Date: Thu, 28 Jun 2018 10:16:12 +0200 [thread overview]
Message-ID: <20180628081612.GB16727@lunn.ch> (raw)
In-Reply-To: <20180627181618.23463-1-dmurphy@ti.com>
> err = phy_write(phydev, MII_DP83811_INT_STAT1, 0);
> if (err < 0)
> return err;
>
> - err = phy_write(phydev, MII_DP83811_INT_STAT1, 0);
> + err = phy_write(phydev, MII_DP83811_INT_STAT2, 0);
> + if (err < 0)
> + return err;
> +
> + err = phy_write(phydev, MII_DP83811_INT_STAT3, 0);
> }
>
Hi Dan
This seems like a bug fix, and so should be in a patch of its own, for
net, not net-next.
Andrew
next prev parent reply other threads:[~2018-06-28 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 18:16 [PATCH 1/2] net: phy: DP83TC811: Add INT_STAT3 Dan Murphy
2018-06-27 18:16 ` [PATCH 2/2] net: phy: DP83TC811: Fix SGMII enable/disable Dan Murphy
2018-06-28 8:20 ` Andrew Lunn
2018-06-28 11:53 ` Dan Murphy
2018-06-28 8:16 ` Andrew Lunn [this message]
2018-06-28 11:54 ` [PATCH 1/2] net: phy: DP83TC811: Add INT_STAT3 Dan Murphy
2018-06-28 12:04 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628081612.GB16727@lunn.ch \
--to=andrew@lunn.ch \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).