From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 2/2] net: phy: DP83TC811: Fix SGMII enable/disable Date: Thu, 28 Jun 2018 10:20:06 +0200 Message-ID: <20180628082006.GC16727@lunn.ch> References: <20180627181618.23463-1-dmurphy@ti.com> <20180627181618.23463-2-dmurphy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: f.fainelli@gmail.com, netdev@vger.kernel.org To: Dan Murphy Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:45382 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932361AbeF1IUI (ORCPT ); Thu, 28 Jun 2018 04:20:08 -0400 Content-Disposition: inline In-Reply-To: <20180627181618.23463-2-dmurphy@ti.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jun 27, 2018 at 01:16:18PM -0500, Dan Murphy wrote: > If SGMII was selected in the DT then the device should > write the SGMII enable bit. > > If SGMII is not selected in the DT then the SGMII bit > should be disabled. > > Signed-off-by: Dan Murphy > --- > arch/arm/configs/omap2plus_defconfig | 1 + > drivers/net/phy/dp83tc811.c | 20 +++++++++----------- > 2 files changed, 10 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig > index 06fb948ecfb3..30857d5b7a6c 100644 > --- a/arch/arm/configs/omap2plus_defconfig > +++ b/arch/arm/configs/omap2plus_defconfig > @@ -182,6 +182,7 @@ CONFIG_TI_CPTS=y > CONFIG_AT803X_PHY=y > CONFIG_DP83848_PHY=y > CONFIG_DP83867_PHY=y > +CONFIG_DP83TC811_PHY=y > CONFIG_MICREL_PHY=y > CONFIG_SMSC_PHY=y > CONFIG_PPP=m Hi Dan This change does not belong here. Andrew