From: Jiri Benc <jbenc@redhat.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
davem@davemloft.net, Roopa Prabhu <roopa@cumulusnetworks.com>,
jiri@resnulli.us, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
oss-drivers@netronome.com, netdev@vger.kernel.org,
Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Subject: Re: [PATCH net-next v2 3/4] net: check tunnel option type in tunnel flags
Date: Thu, 28 Jun 2018 09:42:06 +0200 [thread overview]
Message-ID: <20180628094206.62b6d8e2@redhat.com> (raw)
In-Reply-To: <c426f1d5-e317-0564-d2f7-3bb8662479c7@iogearbox.net>
On Wed, 27 Jun 2018 11:49:49 +0200, Daniel Borkmann wrote:
> Looks good to me, and yes in BPF case a mask like TUNNEL_OPTIONS_PRESENT is
> right approach since this is opaque info and solely defined by the BPF prog
> that is using the generic helper.
Wouldn't it make sense to introduce some safeguards here (in a backward
compatible way, of course)? It's easy to mistakenly set data for a
different tunnel type in a BPF program and then be surprised by the
result. It might help users if such usage was detected by the kernel,
one way or another.
I'm thinking about something like the BPF program voluntarily
specifying the type of the data; if not specified, the wildcard would be
used as it is now.
Jiri
next prev parent reply other threads:[~2018-06-28 7:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 4:39 [PATCH net-next v2 0/4] net: Geneve options support for TC act_tunnel_key Jakub Kicinski
2018-06-27 4:39 ` [PATCH net-next v2 1/4] net/sched: act_tunnel_key: disambiguate metadata dst error cases Jakub Kicinski
2018-06-27 4:39 ` [PATCH net-next v2 2/4] net/sched: act_tunnel_key: add extended ack support Jakub Kicinski
2018-06-27 4:39 ` [PATCH net-next v2 3/4] net: check tunnel option type in tunnel flags Jakub Kicinski
2018-06-27 9:49 ` Daniel Borkmann
2018-06-28 7:42 ` Jiri Benc [this message]
2018-06-28 16:54 ` Jakub Kicinski
2018-06-28 17:01 ` Jiri Benc
2018-06-28 17:05 ` Jakub Kicinski
2018-06-29 9:06 ` Jiri Benc
2018-06-29 7:04 ` Daniel Borkmann
2018-06-29 17:01 ` Jakub Kicinski
2018-06-30 8:47 ` Daniel Borkmann
2018-06-27 4:39 ` [PATCH net-next v2 4/4] net/sched: add tunnel option support to act_tunnel_key Jakub Kicinski
2018-06-29 14:51 ` [PATCH net-next v2 0/4] net: Geneve options support for TC act_tunnel_key David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628094206.62b6d8e2@redhat.com \
--to=jbenc@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=roopa@cumulusnetworks.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).