* [PATCH] net: phy: DP83TC811: Fix diabling interrupts
@ 2018-06-28 12:13 Dan Murphy
2018-06-28 12:47 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Dan Murphy @ 2018-06-28 12:13 UTC (permalink / raw)
To: andrew, f.fainelli; +Cc: netdev, Dan Murphy
Fix a bug where INT_STAT1 was written twice and
INT_STAT2 was ignored when disabling interrupts.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
drivers/net/phy/dp83tc811.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index 081d99aa3985..49ac678eb2dc 100644
--- a/drivers/net/phy/dp83tc811.c
+++ b/drivers/net/phy/dp83tc811.c
@@ -222,7 +222,7 @@ static int dp83811_config_intr(struct phy_device *phydev)
if (err < 0)
return err;
- err = phy_write(phydev, MII_DP83811_INT_STAT1, 0);
+ err = phy_write(phydev, MII_DP83811_INT_STAT2, 0);
}
return err;
--
2.17.0.582.gccdcbd54c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: phy: DP83TC811: Fix diabling interrupts
2018-06-28 12:13 [PATCH] net: phy: DP83TC811: Fix diabling interrupts Dan Murphy
@ 2018-06-28 12:47 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2018-06-28 12:47 UTC (permalink / raw)
To: Dan Murphy; +Cc: f.fainelli, netdev
On Thu, Jun 28, 2018 at 07:13:32AM -0500, Dan Murphy wrote:
> Fix a bug where INT_STAT1 was written twice and
> INT_STAT2 was ignored when disabling interrupts.
Hi Dan
You should put in the subject line which tree this is for, eg.
[PATCH net].
Also, you should add a fixes tag, indicating when this bug as added.
Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-28 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-28 12:13 [PATCH] net: phy: DP83TC811: Fix diabling interrupts Dan Murphy
2018-06-28 12:47 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).