From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH bpf-next 2/7] lib: reciprocal_div: implement the
 improved algorithm on the paper mentioned
Date: Thu, 28 Jun 2018 14:05:03 -0700
Message-ID: <20180628140503.555a5ba5@cakuba.netronome.com>
References: <CAMsOgNDapubGdbP=nB8r8Mps5pMtjK9CSr3sn-LvDCOvyCg4Wg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Song Liu <liu.song.a23@gmail.com>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        oss-drivers@netronome.com, Networking <netdev@vger.kernel.org>
To: Jiong Wang <jiong.wang@netronome.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt0-f174.google.com ([209.85.216.174]:46959 "EHLO
        mail-qt0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753207AbeF1VFI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 28 Jun 2018 17:05:08 -0400
Received: by mail-qt0-f174.google.com with SMTP id h5-v6so6056557qtm.13
        for <netdev@vger.kernel.org>; Thu, 28 Jun 2018 14:05:07 -0700 (PDT)
In-Reply-To: <CAMsOgNDapubGdbP=nB8r8Mps5pMtjK9CSr3sn-LvDCOvyCg4Wg@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 28 Jun 2018 20:02:43 +0100, Jiong Wang wrote:
> > If that's the case, we should at least add a WARNING on the slow path.  
> 
> OK, I will add a pr_warn inside "reciprocal_value_adv" when l == 32 is
> triggered.

WARN() seems useful, given seeing l == 32 means the code calling this
function is buggy, and we want to see the back trace to figure out how
it happened.