From: Christoph Hellwig <hch@lst.de>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org,
lkp@01.org
Subject: [PATCH 3/6] net: don't detour through struct to find the poll head
Date: Thu, 28 Jun 2018 16:20:56 +0200 [thread overview]
Message-ID: <20180628142059.10017-4-hch@lst.de> (raw)
In-Reply-To: <20180628142059.10017-1-hch@lst.de>
As far as I can tell sock->sk->sk_wq->wait will always point to
sock->wq->wait. That means we can do the shorter dereference and
not worry about any RCU protection.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
net/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/socket.c b/net/socket.c
index fe6620607b07..7cf037d21805 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -1136,7 +1136,7 @@ static struct wait_queue_head *sock_get_poll_head(struct file *file,
if (!sock->ops->poll_mask)
return NULL;
sock_poll_busy_loop(sock, events);
- return sk_sleep(sock->sk);
+ return &sock->wq->wait;
}
static __poll_t sock_poll_mask(struct file *file, __poll_t events)
--
2.17.1
next prev parent reply other threads:[~2018-06-28 14:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 14:20 [RFC] replace ->get_poll_head with a waitqueue pointer in struct file Christoph Hellwig
2018-06-28 14:20 ` [PATCH 1/6] net: remove sock_poll_busy_flag Christoph Hellwig
2018-06-28 14:20 ` [PATCH 2/6] net: remove bogus RCU annotations on socket.wq Christoph Hellwig
2018-06-28 14:20 ` Christoph Hellwig [this message]
2018-06-28 14:20 ` [PATCH 4/6] net: remove busy polling from sock_get_poll_head Christoph Hellwig
2018-06-28 14:20 ` [PATCH 5/6] net: remove sock_poll_busy_loop Christoph Hellwig
2018-06-28 14:20 ` [PATCH 6/6] fs: replace f_ops->get_poll_head with a static ->f_poll_head pointer Christoph Hellwig
2018-06-28 16:40 ` Linus Torvalds
2018-06-28 18:17 ` Al Viro
2018-06-28 19:31 ` Linus Torvalds
2018-06-28 20:28 ` Al Viro
2018-06-28 20:37 ` Al Viro
2018-06-28 21:16 ` Linus Torvalds
2018-06-28 21:11 ` Linus Torvalds
2018-06-28 21:30 ` Al Viro
2018-06-28 21:39 ` Linus Torvalds
2018-06-28 22:20 ` Al Viro
2018-06-28 22:35 ` Linus Torvalds
2018-06-28 22:49 ` Al Viro
2018-06-28 22:55 ` Linus Torvalds
2018-06-28 23:37 ` Al Viro
2018-06-29 0:13 ` Linus Torvalds
2018-06-29 13:29 ` Christoph Hellwig
2018-06-29 13:40 ` Linus Torvalds
2018-06-29 13:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628142059.10017-4-hch@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkp@01.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).