From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH v12 03/10] netdev: cavium: octeon: Add Octeon III BGX
 Ethernet Nexus
Date: Fri, 29 Jun 2018 08:13:20 +0200
Message-ID: <20180629061320.GA2195@nanopsycho.orion>
References: <1530134719-19407-4-git-send-email-steven.hill@cavium.com>
 <20180628084156.GF16727@lunn.ch>
 <f09305d1-8477-ed79-0289-05a629cef994@cavium.com>
 <20180629.111905.863023692523959153.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: cmunoz@cavium.com, andrew@lunn.ch, steven.hill@cavium.com,
        netdev@vger.kernel.org, cchavva@caviumnetworks.com
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f193.google.com ([209.85.128.193]:46275 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753232AbeF2GOu (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 29 Jun 2018 02:14:50 -0400
Received: by mail-wr0-f193.google.com with SMTP id t6-v6so7612406wrq.13
        for <netdev@vger.kernel.org>; Thu, 28 Jun 2018 23:14:50 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180629.111905.863023692523959153.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Fri, Jun 29, 2018 at 04:19:05AM CEST, davem@davemloft.net wrote:
>From: Carlos Munoz <cmunoz@cavium.com>
>Date: Thu, 28 Jun 2018 14:20:05 -0700
>
>> 
>> 
>> On 06/28/2018 01:41 AM, Andrew Lunn wrote:
>>> External Email
>>>
>>>> +static char *mix_port;
>>>> +module_param(mix_port, charp, 0444);
>>>> +MODULE_PARM_DESC(mix_port, "Specifies which ports connect to MIX interfaces.");
>>>> +
>>>> +static char *pki_port;
>>>> +module_param(pki_port, charp, 0444);
>>>> +MODULE_PARM_DESC(pki_port, "Specifies which ports connect to the PKI.");
>>> Module parameters are generally not liked. Can you do without them?
>> 
>> These parameters change the kernel port assignment required by user
>> space applications. We rather keep them as they simplify the
>> process.
>
>This is actually a terrible user experience.
>
>Please provide a way to do this by performing operations on a device object
>after the driver loads.
>
>Use something like devlink or similar if you have to.

Devlink params should be used for this. They are not upstream yet. We
will push it most likely early next week.