From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [patch net-next v2 0/9] net: sched: introduce chain templates
 support with offloading to mlxsw
Date: Fri, 29 Jun 2018 10:39:10 +0200
Message-ID: <20180629083910.GB2195@nanopsycho.orion>
References: <20180628130907.951-1-jiri@resnulli.us>
 <CAM_iQpVHQHHfi1oaFbEXsGK2c8ryjuZ8SxxR54Kpbh-BBKcEQg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Simon Horman <simon.horman@netronome.com>,
        john.hurley@netronome.com, David Ahern <dsahern@gmail.com>,
        mlxsw@mellanox.com, sridhar.samudrala@intel.com
To: Cong Wang <xiyou.wangcong@gmail.com>, g@nanopsycho.orion
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f194.google.com ([209.85.128.194]:38275 "EHLO
        mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965371AbeF2Ikl (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 29 Jun 2018 04:40:41 -0400
Received: by mail-wr0-f194.google.com with SMTP id w16-v6so282283wrn.5
        for <netdev@vger.kernel.org>; Fri, 29 Jun 2018 01:40:40 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAM_iQpVHQHHfi1oaFbEXsGK2c8ryjuZ8SxxR54Kpbh-BBKcEQg@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Fri, Jun 29, 2018 at 12:25:53AM CEST, xiyou.wangcong@gmail.com wrote:
>On Thu, Jun 28, 2018 at 6:10 AM Jiri Pirko <jiri@resnulli.us> wrote:
>> Add a template of type flower allowing to insert rules matching on last
>> 2 bytes of destination mac address:
>> # tc chaintemplate add dev dummy0 ingress proto ip flower dst_mac 00:00:00:00:00:00/00:00:00:00:FF:FF
>>
>> The template is now showed in the list:
>> # tc chaintemplate show dev dummy0 ingress
>> chaintemplate flower chain 0
>>   dst_mac 00:00:00:00:00:00/00:00:00:00:ff:ff
>>   eth_type ipv4
>>
>> Add another template, this time for chain number 22:
>> # tc chaintemplate add dev dummy0 ingress proto ip chain 22 flower dst_ip 0.0.0.0/16
>> # tc chaintemplate show dev dummy0 ingress
>> chaintemplate flower chain 0
>>   dst_mac 00:00:00:00:00:00/00:00:00:00:ff:ff
>>   eth_type ipv4
>> chaintemplate flower chain 22
>>   eth_type ipv4
>>   dst_ip 0.0.0.0/16
>
>So, if I want to check the template of a chain, I have to use
>'tc chaintemplate... chain X'.
>
>If I want to check the filters in a chain, I have to use
>'tc filter show .... chain X'.
>
>If you introduce 'tc chain', it would just need one command:
>`tc chain show ... X` which could list its template first and
>followed by filters in this chain, something like:
>
># tc chain show dev eth0 chain X
>template: # could be none
>....
>filter1
>...
>filter2
>...
>
>Isn't it more elegant?

Well, that is just another iproute2 command. It would use the same
kernel uapi. Filters+templates. Sure, why not. Can be easily introduced.
Let's do it in a follow-up iproute2 patch.