From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
tglx@linutronix.de, "David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
Subject: Re: [1/4] ath9k: use irqsave() in USB's complete callback
Date: Fri, 29 Jun 2018 11:56:42 +0000 (UTC) [thread overview]
Message-ID: <20180629115642.51C5160AFF@smtp.codeaurora.org> (raw)
In-Reply-To: <20180620193648.25136-2-bigeasy@linutronix.de>
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> The USB completion callback does not disable interrupts while acquiring
> the lock. We want to remove the local_irq_disable() invocation from
> __usb_hcd_giveback_urb() and therefore it is required for the callback
> handler to disable the interrupts while acquiring the lock.
> The callback may be invoked either in IRQ or BH context depending on the
> USB host controller.
> Use the _irqsave() variant of the locking primitives.
>
> Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-wireless@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
84a0d4669c8f ath9k: use irqsave() in USB's complete callback
--
https://patchwork.kernel.org/patch/10478601/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-06-29 11:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 19:36 [PATCH 0/4] wireless: Use irqsave in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 19:36 ` [PATCH 2/4] libertas_tf: use irqsave() " Sebastian Andrzej Siewior
2018-06-27 16:13 ` [2/4] " Kalle Valo
[not found] ` <20180620193648.25136-1-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2018-06-20 19:36 ` [PATCH 1/4] ath9k: " Sebastian Andrzej Siewior
2018-06-29 11:56 ` Kalle Valo [this message]
2018-06-20 19:36 ` [PATCH 3/4] libertas: " Sebastian Andrzej Siewior
2018-06-20 19:36 ` [PATCH 4/4] zd1211rw: " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629115642.51C5160AFF@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).