From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] r8169: remove TBI 1000BaseX support Date: Sat, 30 Jun 2018 20:54:43 +0900 (KST) Message-ID: <20180630.205443.1624830055097480523.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nic_swsd@realtek.com, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:37888 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936201AbeF3Lyq (ORCPT ); Sat, 30 Jun 2018 07:54:46 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Fri, 29 Jun 2018 08:07:04 +0200 > The very first version of RTL8169 from 2002 (and only this one) has > support for a TBI 1000BaseX fiber interface. The TBI support in the > driver makes switching to phylib tricky, so best would be to get > rid of it. I found no report from anybody using a device with RTL8169 > and fiber interface, also the vendor driver doesn't support this mode > (any longer). > So remove TBI support and bail out with a message if a card with > activated TBI is detected. If there really should be any user of it > out there, we could add a stripped-down version of the driver > supporting chip version 01 and TBI only (and maybe move it to > staging). > > Signed-off-by: Heiner Kallweit Ok, I guess this is reasonable. Applied, but it will be a mini-disaster if someone is actually making use of this fiber support for whatever reason.