From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] alx: take rtnl before calling __alx_open from resume Date: Sat, 30 Jun 2018 21:18:40 +0900 (KST) Message-ID: <20180630.211840.2037097532737615495.davem@davemloft.net> References: <39bd16f9cc1df96df0fcd49e65de4fefc8b0c067.1530285973.git.sd@queasysnail.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tobias.regnery@gmail.com To: sd@queasysnail.net Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:38180 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030256AbeF3MSn (ORCPT ); Sat, 30 Jun 2018 08:18:43 -0400 In-Reply-To: <39bd16f9cc1df96df0fcd49e65de4fefc8b0c067.1530285973.git.sd@queasysnail.net> Sender: netdev-owner@vger.kernel.org List-ID: From: Sabrina Dubroca Date: Fri, 29 Jun 2018 17:51:26 +0200 > The __alx_open function can be called from ndo_open, which is called > under RTNL, or from alx_resume, which isn't. Since commit d768319cd427, > we're calling the netif_set_real_num_{tx,rx}_queues functions, which > need to be called under RTNL. > > This is similar to commit 0c2cc02e571a ("igb: Move the calls to set the > Tx and Rx queues into igb_open"). > > Fixes: d768319cd427 ("alx: enable multiple tx queues") > Signed-off-by: Sabrina Dubroca Applied and queued up for -stable.