From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] strparser: Call skb_unclone conditionally Date: Sat, 30 Jun 2018 21:25:58 +0900 (KST) Message-ID: <20180630.212558.1206392832287735000.davem@davemloft.net> References: <20180629191555.19874-1-vakul.garg@nxp.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tom@quantonium.net, borisp@mellanox.com, ebiggers@google.com, davejwatson@fb.com, doronrk@fb.com To: vakul.garg@nxp.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:38260 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030214AbeF3M0B (ORCPT ); Sat, 30 Jun 2018 08:26:01 -0400 In-Reply-To: <20180629191555.19874-1-vakul.garg@nxp.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Vakul Garg Date: Sat, 30 Jun 2018 00:45:55 +0530 > Calling skb_unclone() is expensive as it triggers a memcpy operation. > Instead of calling skb_unclone() unconditionally, call it only when skb > has a shared frag_list. This improves tls rx throughout significantly. > > Signed-off-by: Vakul Garg > Suggested-by: Boris Pismenny Applied.