From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] hv_netvsc: split sub-channel setup into async and sync Date: Sat, 30 Jun 2018 21:29:30 +0900 (KST) Message-ID: <20180630.212930.58049848439397621.davem@davemloft.net> References: <20180629210716.6798-1-haiyangz@linuxonhyperv.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: olaf@aepfle.de, sthemmin@microsoft.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, vkuznets@redhat.com To: haiyangz@microsoft.com, haiyangz@linuxonhyperv.com Return-path: In-Reply-To: <20180629210716.6798-1-haiyangz@linuxonhyperv.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org From: Haiyang Zhang Date: Fri, 29 Jun 2018 14:07:16 -0700 > From: Stephen Hemminger > > When doing device hotplug the sub channel must be async to avoid > deadlock issues because device is discovered in softirq context. > > When doing changes to MTU and number of channels, the setup > must be synchronous to avoid races such as when MTU and device > settings are done in a single ip command. > > Reported-by: Thomas Walker > Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug") > Fixes: 732e49850c5e ("netvsc: fix race on sub channel creation") > Signed-off-by: Stephen Hemminger > Signed-off-by: Haiyang Zhang Applied and queued up for -stable.