From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] r8169: remove old PHY reset hack Date: Mon, 02 Jul 2018 22:42:33 +0900 (KST) Message-ID: <20180702.224233.258709511328151388.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nic_swsd@realtek.com, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:50684 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752391AbeGBNmg (ORCPT ); Mon, 2 Jul 2018 09:42:36 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Sun, 1 Jul 2018 00:25:19 +0200 > This hack (affecting the non-PCIe models only) was introduced in 2004 > to deal with link negotiation failures in 1GBit mode. Based on a > comment in the r8169 vendor driver I assume the issue affects RTL8169sb > in combination with particular 1GBit switch models. > > Resetting the PHY every 10s and hoping that one fine day we will make > it to establish the link seems to be very hacky to me. I'd say: > If 1GBit doesn't work reliably in a users environment then the user > should remove 1GBit from the advertised modes, e.g. by using > ethtool -s advertise <10/100 modes> > > If the issue affects one chip version only and that with most link > partners, then we could also think of removing 1GBit from the > advertised modes for this chip version in the driver. > > Signed-off-by: Heiner Kallweit Applied.