From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: stmmac_tc: use 64-bit arithmetic instead of 32-bit Date: Tue, 03 Jul 2018 23:21:29 +0900 (KST) Message-ID: <20180703.232129.1258523191108623986.davem@davemloft.net> References: <20180702120932.GA13079@embeddedor.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: gustavo@embeddedor.com Return-path: In-Reply-To: <20180702120932.GA13079@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: "Gustavo A. R. Silva" Date: Mon, 2 Jul 2018 07:09:32 -0500 > Add suffix UL to constant 1024 in order to give the compiler complete > information about the proper arithmetic to use. Notice that this > constant is used in a context that expects an expression of type > u64 (64 bits, unsigned) and following expressions are currently > being evaluated using 32-bit arithmetic: > > qopt->idleslope * 1024 * ptr > qopt->hicredit * 1024 * 8 > qopt->locredit * 1024 * 8 > > Addresses-Coverity-ID: 1470246 ("Unintentional integer overflow") > Addresses-Coverity-ID: 1470248 ("Unintentional integer overflow") > Addresses-Coverity-ID: 1470249 ("Unintentional integer overflow") > Signed-off-by: Gustavo A. R. Silva Applied.