From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] lib: rhashtable: Correct self-assignment in rhashtable.c Date: Tue, 03 Jul 2018 23:26:09 +0900 (KST) Message-ID: <20180703.232609.1284380263316778825.davem@davemloft.net> References: <1530549334-13890-1-git-send-email-rishabhb@codeaurora.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, neilb@suse.com, tgraf@suug.ch, herbert@gondor.apana.org.au, linux-arm-msm@vger.kernel.org To: rishabhb@codeaurora.org Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:43578 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752745AbeGCO0M (ORCPT ); Tue, 3 Jul 2018 10:26:12 -0400 In-Reply-To: <1530549334-13890-1-git-send-email-rishabhb@codeaurora.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Rishabh Bhatnagar Date: Mon, 2 Jul 2018 09:35:34 -0700 > In file lib/rhashtable.c line 777, skip variable is assigned to > itself. The following error was observed: > > lib/rhashtable.c:777:41: warning: explicitly assigning value of > variable of type 'int' to itself [-Wself-assign] error, forbidden > warning: rhashtable.c:777 > This error was found when compiling with Clang 6.0. Change it to iter->skip. > > Signed-off-by: Rishabh Bhatnagar > Acked-by: Herbert Xu > Reviewed-by: NeilBrown Applied, thanks.