From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corinna Vinschen Subject: Re: [PATCH net] r8169: fix mac address change Date: Tue, 3 Jul 2018 10:47:47 +0200 Message-ID: <20180703084747.GH3111@calimero.vinschen.de> References: <1770bc23-75f1-d462-b8a3-61e81ade4c3c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: David Miller , "netdev@vger.kernel.org" To: Heiner Kallweit Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754218AbeGCIrt (ORCPT ); Tue, 3 Jul 2018 04:47:49 -0400 Content-Disposition: inline In-Reply-To: <1770bc23-75f1-d462-b8a3-61e81ade4c3c@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Jul 2 22:49, Heiner Kallweit wrote: > Network core refuses to change mac address because flag > IFF_LIVE_ADDR_CHANGE isn't set. Set this missing flag. > > Fixes: 1f7aa2bc268e ("r8169: simplify rtl_set_mac_address") > Reported-by: Corinna Vinschen > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet/realtek/r8169.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c > index f80ac894..a390db27 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -7607,6 +7607,7 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > NETIF_F_HW_VLAN_CTAG_RX; > dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO | > NETIF_F_HIGHDMA; > + dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; > > tp->cp_cmd |= RxChkSum | RxVlan; > > -- > 2.18.0 Tested-by: Corinna Vinschen This patch allows to change the MAC any time, just as before 1f7aa2bc268e, and thus also fixes the problem reported in https://www.spinics.net/lists/netdev/msg510926.html Thanks, Corinna