From: Ido Schimmel <idosch@mellanox.com>
To: dsahern@kernel.org
Cc: netdev@vger.kernel.org, sharpd@cumulusnetworks.com,
Thomas.Winter@alliedtelesis.co.nz,
David Ahern <dsahern@gmail.com>,
petrm@mellanox.com
Subject: Re: [PATCH net] net/ipv6: Revert attempt to simplify route replace and append
Date: Tue, 3 Jul 2018 16:43:02 +0300 [thread overview]
Message-ID: <20180703134302.GB15120@splinter.mtl.com> (raw)
In-Reply-To: <20180702220312.14590-1-dsahern@kernel.org>
On Mon, Jul 02, 2018 at 03:03:12PM -0700, dsahern@kernel.org wrote:
> From: David Ahern <dsahern@gmail.com>
>
> NetworkManager likes to manage linklocal prefix routes and does so with
> the NLM_F_APPEND flag, breaking attempts to simplify the IPv6 route
> code and by extension enable multipath routes with device only nexthops.
>
> Revert f34436a43092 and its followup
> 6eba08c3626b ("ipv6: Only emit append events for appended routes").
> Update the test cases to reflect the old behavior.
>
> Fixes: f34436a43092 ("net/ipv6: Simplify route replace and appending into multipath route")
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> Ido: I left 5a15a1b07c51. FIB_EVENT_ENTRY_APPEND is not generated for
> IPv6, so no harm in leaving it.
OK, but I had a follow-up series that did further changes in mlxsw
(merge commit eab9a2d5f323) to support the new behavior. You want to
revert it and squash to v2 or I'll send another revert?
Also, Petr added a multipath test that relies on IPv6 device only
nexthops. See commit 54818c4c4b937.
next prev parent reply other threads:[~2018-07-03 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 22:03 [PATCH net] net/ipv6: Revert attempt to simplify route replace and append dsahern
2018-07-03 13:43 ` Ido Schimmel [this message]
2018-07-03 20:02 ` David Ahern
2018-07-04 21:10 ` Ido Schimmel
2018-07-05 2:29 ` David Miller
2018-07-05 3:01 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703134302.GB15120@splinter.mtl.com \
--to=idosch@mellanox.com \
--cc=Thomas.Winter@alliedtelesis.co.nz \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=sharpd@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).