From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/3 v2] net: phy: vitesse: Add support for VSC73xx Date: Wed, 04 Jul 2018 11:32:30 +0900 (KST) Message-ID: <20180704.113230.1134845998887388983.davem@davemloft.net> References: <20180630111731.19551-1-linus.walleij@linaro.org> <20180630111731.19551-2-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, openwrt-devel@lists.openwrt.org, lede-dev@lists.infradead.org, juhosg@openwrt.org To: linus.walleij@linaro.org Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:55236 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932644AbeGDCcf (ORCPT ); Tue, 3 Jul 2018 22:32:35 -0400 In-Reply-To: <20180630111731.19551-2-linus.walleij@linaro.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Linus Walleij Date: Sat, 30 Jun 2018 13:17:30 +0200 > The VSC7385, VSC7388, VSC7395 and VSC7398 are integrated > switch/router chips for 5+1 or 8-port switches/routers. When > managed directly by Linux using DSA we need to do a special > set-up "dance" on the PHY. Unfortunately these sequences > switches the PHY to undocumented pages named 2a30 and 52b6 > and does undocumented things. It is described by these opaque > sequences also in the reference manual. This is a best > effort to integrate it anyways. > > Reviewed-by: Florian Fainelli > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Drop from an earlier iteration. > - Implement an .config_aneg() routine that does nothing: the > imroved genphy_config_aneg() makes the device fail as of > v4.18-rc1 and the device seems to feel best like this: it > comes up in autonegotiation mode and we do not try to instruct > it. > - Use some MII defines when reading/writing registers. > - Collect Florian's ACK. Applied.