From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Paulius Zaleckas" <paulius.zaleckas@gmail.com>,
"Hans Ulli Kroll" <ulli.kroll@googlemail.com>,
"Janos Laube" <janos.dev@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 5/5 v2] net: gemini: Indicate that we can handle jumboframes
Date: Wed, 4 Jul 2018 22:35:56 +0200 [thread overview]
Message-ID: <20180704203556.GC23469@lunn.ch> (raw)
In-Reply-To: <20180704183324.10605-5-linus.walleij@linaro.org>
On Wed, Jul 04, 2018 at 08:33:24PM +0200, Linus Walleij wrote:
> The hardware supposedly handles frames up to 10236 bytes and
> implements .ndo_change_mtu() so accept 10236 minus the ethernet
> header for a VLAN tagged frame on the netdevices. Use
> ETH_MIN_MTU as minimum MTU.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Hi Linus
Did you try with an MTU of 68? Maybe the vendor picked 256 because of
a hardware limit?
Otherwise the change looks good.
Andrew
next prev parent reply other threads:[~2018-07-04 20:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 18:33 [PATCH net-next 1/5 v2] net: gemini: Look up L3 maxlen from table Linus Walleij
2018-07-04 18:33 ` [PATCH net-next 2/5 v2] net: gemini: Improve connection prints Linus Walleij
2018-07-04 20:40 ` Andrew Lunn
2018-07-08 20:47 ` Linus Walleij
2018-07-04 18:33 ` [PATCH net-next 3/5 v2] net: gemini: Allow multiple ports to instantiate Linus Walleij
2018-07-04 18:33 ` [PATCH net-next 4/5 v2] net: gemini: Move main init to port Linus Walleij
2018-07-04 18:33 ` [PATCH net-next 5/5 v2] net: gemini: Indicate that we can handle jumboframes Linus Walleij
2018-07-04 20:35 ` Andrew Lunn [this message]
2018-07-11 19:10 ` Linus Walleij
2018-07-07 16:14 ` [PATCH net-next 1/5 v2] net: gemini: Look up L3 maxlen from table Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704203556.GC23469@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=janos.dev@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@gmail.com \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).