From: Ido Schimmel <idosch@mellanox.com>
To: David Ahern <dsahern@gmail.com>
Cc: dsahern@kernel.org, netdev@vger.kernel.org,
sharpd@cumulusnetworks.com, Thomas.Winter@alliedtelesis.co.nz,
petrm@mellanox.com
Subject: Re: [PATCH net] net/ipv6: Revert attempt to simplify route replace and append
Date: Thu, 5 Jul 2018 00:10:41 +0300 [thread overview]
Message-ID: <20180704211041.GB24525@splinter> (raw)
In-Reply-To: <e0f62775-a7e0-ad4e-5eaa-a6ecb3b2c8db@gmail.com>
On Tue, Jul 03, 2018 at 02:02:06PM -0600, David Ahern wrote:
> It is unfortunate that mlxsw has to replicate the node lookup code.
The kernel can store multiple routes with the same prefix/length, but
only one is used for forwarding. Thus when a route is deleted it should
be potentially overwritten by a different route in the device's tables.
This is why mlxsw stores these nodes.
We can have the IPv4/IPv6 code only generate a REPLACE / DELETE
notification for routes that are actually used for forwarding and
relieve listeners from the need to implement this logic themselves. I
think this should work.
?
next prev parent reply other threads:[~2018-07-04 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 22:03 [PATCH net] net/ipv6: Revert attempt to simplify route replace and append dsahern
2018-07-03 13:43 ` Ido Schimmel
2018-07-03 20:02 ` David Ahern
2018-07-04 21:10 ` Ido Schimmel [this message]
2018-07-05 2:29 ` David Miller
2018-07-05 3:01 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704211041.GB24525@splinter \
--to=idosch@mellanox.com \
--cc=Thomas.Winter@alliedtelesis.co.nz \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=sharpd@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).