From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] net: mv __dev_notify_flags from void to int
Date: Thu, 05 Jul 2018 09:49:19 +0900 (KST)
Message-ID: <20180705.094919.1111182514263672077.davem@davemloft.net>
References: <1530685786-26449-1-git-send-email-liuhangbin@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, sbrivio@redhat.com,
        xiyou.wangcong@gmail.com
To: liuhangbin@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:47056 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753009AbeGEAtV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 4 Jul 2018 20:49:21 -0400
In-Reply-To: <1530685786-26449-1-git-send-email-liuhangbin@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Hangbin Liu <liuhangbin@gmail.com>
Date: Wed,  4 Jul 2018 14:29:46 +0800

> @@ -7062,8 +7073,7 @@ int dev_change_flags(struct net_device *dev, unsigned int flags)
>  		return ret;
>  
>  	changes = (old_flags ^ dev->flags) | (old_gflags ^ dev->gflags);
> -	__dev_notify_flags(dev, old_flags, changes);
> -	return ret;
> +	return __dev_notify_flags(dev, old_flags, changes);

By doing this, you will lose any error code returned from dev_open().
That is why we return 'ret' instead of plain '0' here.