From: David Miller <davem@davemloft.net>
To: ecree@solarflare.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: ipv4: fix drop handling in ip_list_rcv() and ip_list_rcv_finish()
Date: Thu, 05 Jul 2018 11:26:05 +0900 (KST) [thread overview]
Message-ID: <20180705.112605.1670394902995823182.davem@davemloft.net> (raw)
In-Reply-To: <7b242192-a58d-a4b7-88a6-e04840e75e10@solarflare.com>
From: Edward Cree <ecree@solarflare.com>
Date: Wed, 4 Jul 2018 19:23:50 +0100
> Since callees (ip_rcv_core() and ip_rcv_finish_core()) might free or steal
> the skb, we can't use the list_cut_before() method; we can't even do a
> list_del(&skb->list) in the drop case, because skb might have already been
> freed and reused.
> So instead, take each skb off the source list before processing, and add it
> to the sublist afterwards if it wasn't freed or stolen.
>
> Fixes: 5fa12739a53d net: ipv4: listify ip_rcv_finish
> Fixes: 17266ee93984 net: ipv4: listified version of ip_rcv
> Signed-off-by: Edward Cree <ecree@solarflare.com>
Applied, thanks Edward.
prev parent reply other threads:[~2018-07-05 2:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 18:23 [PATCH net-next] net: ipv4: fix drop handling in ip_list_rcv() and ip_list_rcv_finish() Edward Cree
2018-07-05 2:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705.112605.1670394902995823182.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).