From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] net/ipv6: Revert attempt to simplify route replace
 and append
Date: Thu, 05 Jul 2018 11:29:35 +0900 (KST)
Message-ID: <20180705.112935.1655283984550635892.davem@davemloft.net>
References: <20180703134302.GB15120@splinter.mtl.com>
        <e0f62775-a7e0-ad4e-5eaa-a6ecb3b2c8db@gmail.com>
        <20180704211041.GB24525@splinter>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: dsahern@gmail.com, dsahern@kernel.org, netdev@vger.kernel.org,
        sharpd@cumulusnetworks.com, Thomas.Winter@alliedtelesis.co.nz,
        petrm@mellanox.com
To: idosch@mellanox.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:48438 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753012AbeGEC3j (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 4 Jul 2018 22:29:39 -0400
In-Reply-To: <20180704211041.GB24525@splinter>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Ido Schimmel <idosch@mellanox.com>
Date: Thu, 5 Jul 2018 00:10:41 +0300

> We can have the IPv4/IPv6 code only generate a REPLACE / DELETE
> notification for routes that are actually used for forwarding and
> relieve listeners from the need to implement this logic themselves. I
> think this should work.

Whilst this could reduce the duplication, I worry that in the long
term that this might end up being error prone.

Just my $0.02