From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH][net-next][v2] net: limit each hash list length to MAX_GRO_SKBS Date: Thu, 05 Jul 2018 19:20:35 +0900 (KST) Message-ID: <20180705.192035.695280292431389546.davem@davemloft.net> References: <1530772472-8674-1-git-send-email-lirongqing@baidu.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: lirongqing@baidu.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:55012 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753342AbeGEKUi (ORCPT ); Thu, 5 Jul 2018 06:20:38 -0400 In-Reply-To: <1530772472-8674-1-git-send-email-lirongqing@baidu.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Li RongQing Date: Thu, 5 Jul 2018 14:34:32 +0800 > After commit 07d78363dcff ("net: Convert NAPI gro list into a small hash > table.")' there is 8 hash buckets, which allows more flows to be held for > merging. but MAX_GRO_SKBS, the total held skb for merging, is 8 skb still, > limit the hash table performance. > > keep MAX_GRO_SKBS as 8 skb, but limit each hash list length to 8 skb, not > the total 8 skb > > Signed-off-by: Li RongQing Applied, thanks.