From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH][V2] net: ethernet: sun: remove redundant variables adv and lpa and mii_reads Date: Thu, 05 Jul 2018 20:08:06 +0900 (KST) Message-ID: <20180705.200806.175025399999006514.davem@davemloft.net> References: <20180705110525.27231-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20180705110525.27231-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Thu, 5 Jul 2018 12:05:25 +0100 > From: Colin Ian King > > Variables adv and lpa are being assigned but are never used hence they > are redundant and can be removed. Also remove the unncessary mii_reads > too. > > Cleans up clang warnings: > warning: variable 'lpa' set but not used [-Wunused-but-set-variable] > warning: variable 'adv' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > --- > > V2: remove mii_reads as suggessted by Dan Carpenter and David Miller Applied, thanks Colin.