From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin King Subject: [PATCH] net: ethernet: sun: remove redundant variables adv and lpa Date: Thu, 5 Jul 2018 10:37:32 +0100 Message-ID: <20180705093732.21650-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: "David S . Miller" , netdev@vger.kernel.org Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin Ian King Variables adv and lpa are being assigned but are never used hence they are redundant and can be removed. Cleans up clang warnings: warning: variable 'lpa' set but not used [-Wunused-but-set-variable] warning: variable 'adv' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King --- drivers/net/ethernet/sun/niu.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index 88c12474a0c3..2d6b62c6d9ab 100644 --- a/drivers/net/ethernet/sun/niu.c +++ b/drivers/net/ethernet/sun/niu.c @@ -1225,17 +1225,13 @@ static int link_status_1g_rgmii(struct niu *np, int *link_up_p) bmsr = err; if (bmsr & BMSR_LSTATUS) { - u16 adv, lpa; - err = mii_read(np, np->phy_addr, MII_ADVERTISE); if (err < 0) goto out; - adv = err; err = mii_read(np, np->phy_addr, MII_LPA); if (err < 0) goto out; - lpa = err; err = mii_read(np, np->phy_addr, MII_ESTATUS); if (err < 0) -- 2.17.1