From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin Ian King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: sun: remove redundant variables adv and lpa
Date: Thu, 5 Jul 2018 13:01:25 +0300 [thread overview]
Message-ID: <20180705100125.blngjkgmzt334fza@mwanda> (raw)
In-Reply-To: <22739fd9-1538-9abf-bfbe-5467196b4acf@canonical.com>
On Thu, Jul 05, 2018 at 10:54:51AM +0100, Colin Ian King wrote:
> On 05/07/18 10:52, Dan Carpenter wrote:
> > On Thu, Jul 05, 2018 at 10:37:32AM +0100, Colin King wrote:
> >> diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c
> >> index 88c12474a0c3..2d6b62c6d9ab 100644
> >> --- a/drivers/net/ethernet/sun/niu.c
> >> +++ b/drivers/net/ethernet/sun/niu.c
> >> @@ -1225,17 +1225,13 @@ static int link_status_1g_rgmii(struct niu *np, int *link_up_p)
> >>
> >> bmsr = err;
> >> if (bmsr & BMSR_LSTATUS) {
> >> - u16 adv, lpa;
> >> -
> >> err = mii_read(np, np->phy_addr, MII_ADVERTISE);
> >> if (err < 0)
> >> goto out;
> >> - adv = err;
> >>
> >> err = mii_read(np, np->phy_addr, MII_LPA);
> >> if (err < 0)
> >> goto out;
> >> - lpa = err;
> >
> > I'm fairly sure we could get rid of the mii_read() calls as well.
>
> I'm always concerned that removing the reads of H/W registers can affect
> the behavior, so I left those in.
Yeah... That's true sometimes. Hence my "fairly sure" equivocation. I
looked to see if any of the original devs are around and it's been a
while since anyone worked on this driver.
When we remove these warnings it means that there is no chance that
someone will look at the code again and remove the unneeded mii_read()
calls. I'm 90% sure the reads are unnecessary.
regards,
dan carpenter
next prev parent reply other threads:[~2018-07-05 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 9:37 [PATCH] net: ethernet: sun: remove redundant variables adv and lpa Colin King
2018-07-05 9:52 ` Dan Carpenter
2018-07-05 9:54 ` Colin Ian King
2018-07-05 10:01 ` Dan Carpenter [this message]
2018-07-05 10:33 ` David Miller
2018-07-05 10:50 ` Colin Ian King
2018-07-05 10:52 ` David Miller
2018-07-05 13:54 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705100125.blngjkgmzt334fza@mwanda \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox