From: John Fastabend <john.fastabend@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net
Cc: netdev@vger.kernel.org, john.fastabend@gmail.com
Subject: [bpf PATCH v2 0/2] sockmap, syzbot fix error path and RCU fix
Date: Thu, 05 Jul 2018 08:05:51 -0700 [thread overview]
Message-ID: <20180705150506.9055.81845.stgit@john-Precision-Tower-5810> (raw)
I missed fixing the error path in the sockhash code to align with
supporting socks in multiple maps. Simply checking if the psock is
present does not mean we can decrement the reference count because
it could be part of another map. Fix this by cleaning up the error
path so this situation does not happen.
---
John Fastabend (2):
bpf: sockmap, error path can not release psock in multi-map case
bpf: sockmap, hash table is RCU so readers do not need locks
kernel/bpf/sockmap.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
next reply other threads:[~2018-07-05 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 15:05 John Fastabend [this message]
2018-07-05 15:05 ` [bpf PATCH v2 1/2] bpf: sockmap, error path can not release psock in multi-map case John Fastabend
2018-07-05 15:06 ` [bpf PATCH v2 2/2] bpf: sockmap, hash table is RCU so readers do not need locks John Fastabend
2018-07-07 22:23 ` [bpf PATCH v2 0/2] sockmap, syzbot fix error path and RCU fix Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705150506.9055.81845.stgit@john-Precision-Tower-5810 \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox