From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v1 net-next 3/9] lan743x: Add support for ethtool
 statistics
Date: Thu, 5 Jul 2018 19:20:16 +0200
Message-ID: <20180705172016.GK23469@lunn.ch>
References: <1530808766-13973-1-git-send-email-Bryan.Whitehead@microchip.com>
 <1530808766-13973-4-git-send-email-Bryan.Whitehead@microchip.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem@davemloft.net, netdev@vger.kernel.org,
        UNGLinuxDriver@microchip.com
To: Bryan Whitehead <Bryan.Whitehead@microchip.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:53084 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753537AbeGERUS (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 5 Jul 2018 13:20:18 -0400
Content-Disposition: inline
In-Reply-To: <1530808766-13973-4-git-send-email-Bryan.Whitehead@microchip.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Bryan

> +static void lan743x_ethtool_get_ethtool_stats(struct net_device *netdev,
> +					      struct ethtool_stats *stats,
> +					      u64 *data)
> +{
> +	struct lan743x_adapter *adapter = netdev_priv(netdev);
> +	int data_index = 0;
> +	u32 buf;
> +	int i;
> +
> +	for (i = 0; i < (sizeof(lan743x_set0_hw_cnt_addr) / (sizeof(u32)));

ARRAY_SIZE(lan743x_set0_hw_cnt_addr) ?

> +	     i++) {
> +		buf = lan743x_csr_read(adapter, lan743x_set0_hw_cnt_addr[i]);
> +		data[data_index++] = (u64)buf;
> +	}
> +	for (i = 0; i < 4; i++)

ARRAY_SIZE(lan743x_set1_sw_cnt_strings) ??

> +		data[data_index++] = (u64)(adapter->rx[i].frame_count);
> +	for (i = 0; i < (sizeof(lan743x_set2_hw_cnt_addr) / (sizeof(u32)));

ARRAY_SIZE()

> +	     i++) {
> +		buf = lan743x_csr_read(adapter, lan743x_set2_hw_cnt_addr[i]);
> +		data[data_index++] = (u64)buf;
> +	}
> +}

  Andrew