From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v1 net-next 5/9] lan743x: Add support for ethtool eeprom
 access
Date: Thu, 5 Jul 2018 19:28:44 +0200
Message-ID: <20180705172844.GL23469@lunn.ch>
References: <1530808766-13973-1-git-send-email-Bryan.Whitehead@microchip.com>
 <1530808766-13973-6-git-send-email-Bryan.Whitehead@microchip.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem@davemloft.net, netdev@vger.kernel.org,
        UNGLinuxDriver@microchip.com
To: Bryan Whitehead <Bryan.Whitehead@microchip.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:53091 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753213AbeGER2q (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 5 Jul 2018 13:28:46 -0400
Content-Disposition: inline
In-Reply-To: <1530808766-13973-6-git-send-email-Bryan.Whitehead@microchip.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Bryan

> +static int lan743x_ethtool_set_eeprom(struct net_device *netdev,
> +				      struct ethtool_eeprom *ee, u8 *data)
> +{
> +	struct lan743x_adapter *adapter = netdev_priv(netdev);
> +	int ret = -EINVAL;
> +
> +	if (ee->magic == LAN743X_EEPROM_MAGIC)
> +		ret = lan743x_eeprom_write(adapter, ee->offset, ee->len,
> +					   data);
> +	/* Beware!  OTP is One Time Programming ONLY!
> +	 * So do some strict condition check before messing up
> +	 */
> +	else if ((ee->magic == LAN743X_OTP_MAGIC) &&
> +		 (ee->offset == 0) &&
> +		 (ee->len == 512) &&

MAX_EEPROM_SIZE ?

> +		 (data[0] == OTP_INDICATOR_1))
> +		ret = lan743x_otp_write(adapter, ee->offset, ee->len, data);
> +
> +	return ret;
> +}

  Andrew