From: David Miller <davem@davemloft.net>
To: igor.russkikh@aquantia.com
Cc: netdev@vger.kernel.org, darcari@redhat.com, pavel.belous@aquantia.com
Subject: Re: [PATCH net] net: aquantia: vlan unicast address list correct handling
Date: Fri, 06 Jul 2018 11:11:46 +0900 (KST) [thread overview]
Message-ID: <20180706.111146.1384912370526565139.davem@davemloft.net> (raw)
In-Reply-To: <6ded5860633d5c93cf5f0e254e61cb17c9a22960.1530714429.git.igor.russkikh@aquantia.com>
From: Igor Russkikh <igor.russkikh@aquantia.com>
Date: Thu, 5 Jul 2018 17:01:09 +0300
> Setting up macvlan/macvtap networks over atlantic NIC results
> in no traffic over these networks because ndo_set_rx_mode did
> not listed UC MACs as registered in unicast filter.
>
> Here we fix that taking into account maximum number of UC
> filters supported by hardware. If more than MAX addresses were
> registered, we just enable promisc and/or allmulti to pass
> the traffic in.
>
> We also remove MULTICAST_ADDRESS_MAX constant from aq_cfg since
> thats not a configurable parameter at all.
>
> Fixes: b21f502 ("net:ethernet:aquantia: Fix for multicast filter handling.")
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Applied and queued up for -stable.
Thanks!
prev parent reply other threads:[~2018-07-06 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1530714429.git.igor.russkikh@aquantia.com>
2018-07-05 14:01 ` [PATCH net] net: aquantia: vlan unicast address list correct handling Igor Russkikh
2018-07-06 2:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706.111146.1384912370526565139.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=darcari@redhat.com \
--cc=igor.russkikh@aquantia.com \
--cc=netdev@vger.kernel.org \
--cc=pavel.belous@aquantia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox