From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowmini Varadhan Subject: Re: [PATCH v2 net-next 1/3] rds: Changing IP address internal representation to struct in6_addr Date: Fri, 6 Jul 2018 06:15:05 -0400 Message-ID: <20180706101505.GA32098@oracle.com> References: <693463ed87c5956eed05a6266c4edf354ab3d51a.1530086216.git.ka-cheong.poon@oracle.com> <6a7b0951-d950-1555-a5b2-622d6f7b9f8f@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ka-Cheong Poon , netdev@vger.kernel.org, rds-devel@oss.oracle.com To: Santosh Shilimkar , davem@davemloft.net Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:44440 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224AbeGFKPR (ORCPT ); Fri, 6 Jul 2018 06:15:17 -0400 Content-Disposition: inline In-Reply-To: <6a7b0951-d950-1555-a5b2-622d6f7b9f8f@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: On (07/06/18 17:08), Ka-Cheong Poon wrote: > >Hmm. Why do you need to include tcp header in ib transport > >code ? If there is any common function just move to core > >common file and use it. > > I think it can be removed as it is left over from earlier > changes when the IB IPv6 listener port was RDS_TCP_PORT. > Now all the port definitions are in rds.h. Transport specific information such as port numbers should not be smeared into the common rds-module. Please fix that. If IB is also piggybacking on port 16385 (why?), please use your own definitions for it in IB specific header files. Santosh, David, I have to NACK this if it is not changed. --Sowmini