From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Roman Gushchin <guro@fb.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-team@fb.com>,
Quentin Monnet <quentin.monnet@netronome.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH bpf-next 1/2] bpftool: introduce cgroup tree command
Date: Fri, 6 Jul 2018 14:03:04 -0700 [thread overview]
Message-ID: <20180706140304.6de698a9@cakuba.netronome.com> (raw)
In-Reply-To: <20180706182542.GA27167@castle.DHCP.thefacebook.com>
On Fri, 6 Jul 2018 11:25:45 -0700, Roman Gushchin wrote:
> > Looks very useful! Minor nits/questions below. I think the reverse
> > mapping could also be interesting - similar to how -f flag shows where
> > program is pinned, we could add a flag which in
> >
> > # bpftool prog show/list
> >
> > adds info about cgroups where the program is attached? Obviously as a
> > future extension.
>
> Well, it would be convenient, but it's not always possible.
> A program can be attached to a dying cgroup (a cgroup which was deleted
> by a user, but still has some associated resources, e.g. pagecache).
Ack, the bpffs and cgroupfs searches are best effort by definition.
Thanks for addressing the other comments!
prev parent reply other threads:[~2018-07-06 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 1:05 [PATCH bpf-next 1/2] bpftool: introduce cgroup tree command Roman Gushchin
2018-07-06 1:05 ` [PATCH bpf-next 2/2] bpftool: document " Roman Gushchin
2018-07-06 2:01 ` Jakub Kicinski
2018-07-06 2:01 ` [PATCH bpf-next 1/2] bpftool: introduce " Jakub Kicinski
2018-07-06 18:25 ` Roman Gushchin
2018-07-06 21:03 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706140304.6de698a9@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox