From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH V2 net-next] liquidio: fix kernel panic when NIC firmware is older than 1.7.2 Date: Sat, 07 Jul 2018 11:10:56 +0900 (KST) Message-ID: <20180707.111056.21259442950793963.davem@davemloft.net> References: <20180706182707.GA1720@felix-thinkpad.cavium.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com, derek.chickles@cavium.com, satananda.burla@cavium.com, ricardo.farrington@cavium.com To: felix.manlunas@cavium.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:41026 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932164AbeGGCK7 (ORCPT ); Fri, 6 Jul 2018 22:10:59 -0400 In-Reply-To: <20180706182707.GA1720@felix-thinkpad.cavium.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Felix Manlunas Date: Fri, 6 Jul 2018 11:27:07 -0700 > From: Rick Farrington > > Pre-1.7.2 NIC firmware does not support (and does not respond to) the "get > speed" command which is sent by the 1.7.2 driver (for CN23XX-225 cards > only) during modprobe. Due to a bug in older firmware (with respect to > unknown commands), this unsupported command causes a cascade of errors that > ends in a kernel panic. > > Fix it by making the sending of the "get speed" command conditional on the > firmware version. > > Signed-off-by: Rick Farrington > Signed-off-by: Felix Manlunas Applied, thanks.