From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: bridge: fix br_vlan_get_{pvid,info} return values Date: Sat, 07 Jul 2018 20:05:26 +0900 (KST) Message-ID: <20180707.200526.1062008433639194322.davem@davemloft.net> References: <20180706124420.3129099-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nikolay@cumulusnetworks.com, jiri@mellanox.com, yotamg@mellanox.com, roopa@cumulusnetworks.com, petrm@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: arnd@arndb.de Return-path: In-Reply-To: <20180706124420.3129099-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Arnd Bergmann Date: Fri, 6 Jul 2018 14:44:02 +0200 > These two functions return the regular -EINVAL failure in the normal > code path, but return a nonstandard '-1' error otherwise, which gets > interpreted as -EPERM. > > Let's change it to -EINVAL for the dummy functions as well. > > Fixes: 4d4fd36126d6 ("net: bridge: Publish bridge accessor functions") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd.