From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] [net-next] devlink: fix incorrect return statement
Date: Sat, 07 Jul 2018 20:07:17 +0900 (KST)
Message-ID: <20180707.200717.1591416060889107341.davem@davemloft.net>
References: <20180706125858.3602497-1-arnd@arndb.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: jiri@mellanox.com, arkadis@mellanox.com, moshe@mellanox.com,
        dsahern@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
To: arnd@arndb.de
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180706125858.3602497-1-arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri,  6 Jul 2018 14:58:51 +0200

> A newly added dummy helper function tries to return a failure from a "void"
> function:
> 
> In file included from include/net/dsa.h:24,
>                  from arch/arm/plat-orion/common.c:21:
> include/net/devlink.h: In function 'devlink_param_value_changed':
> include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror]
>   return -EOPNOTSUPP;
> 
> This fixes it by removing the bogus statement.
> 
> Fixes: ea601e170988 ("devlink: Add devlink notifications support for params")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.