From: David Miller <davem@davemloft.net>
To: 3chas3@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v4,net-next] vlan: implement vlan id and protocol changes
Date: Sat, 07 Jul 2018 20:11:16 +0900 (KST) [thread overview]
Message-ID: <20180707.201116.1526423963748651833.davem@davemloft.net> (raw)
In-Reply-To: <20180702223528.582-1-3chas3@gmail.com>
From: Chas Williams <3chas3@gmail.com>
Date: Mon, 2 Jul 2018 18:35:28 -0400
> vlan_changelink silently ignores attempts to change the vlan id
> or protocol id of an existing vlan interface. Implement by adding
> the new vlan id and protocol to the interface's vlan group and then
> removing the old vlan id and protocol from the vlan group. This
> avoids the netlink churn of deleting and re-adding an interface
> to change the vlan id.
>
> Signed-off-by: Chas Williams <3chas3@gmail.com>
Chas, it seems to me that you add the new notifier by not even one
driver is listening for the event.
Either it is necessary, and you should show at least one example
use case, or it not necessary and therefore should not be added.
next prev parent reply other threads:[~2018-07-07 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 23:19 [PATCH net-next] vlan: implement vlan id and protocol changes Chas Williams
2018-06-11 0:15 ` kbuild test robot
2018-06-11 23:44 ` [PATCH v2 " Chas Williams
2018-06-25 10:30 ` [PATCH v3,net-next] " Chas Williams
2018-06-25 20:45 ` David Ahern
2018-06-26 10:32 ` Ido Schimmel
[not found] ` <CAG2-GkmUJCc2bvOpaXsnUsEeJCLjWeYrs4Xe2kF_9M48FMRTzA@mail.gmail.com>
2018-06-26 15:29 ` Ido Schimmel
[not found] ` <CAG2-Gkm0u3Od64nAMpUzq+=M+cj3VS0J1VQ8L5BChbo7vig+kA@mail.gmail.com>
2018-06-26 15:57 ` Ido Schimmel
2018-07-02 22:35 ` [PATCH v4,net-next] " Chas Williams
2018-07-07 11:11 ` David Miller [this message]
2018-07-07 13:14 ` Ido Schimmel
2018-07-08 1:23 ` David Ahern
2018-07-08 1:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180707.201116.1526423963748651833.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=3chas3@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).