From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v4,net-next] vlan: implement vlan id and protocol
 changes
Date: Sat, 07 Jul 2018 20:11:16 +0900 (KST)
Message-ID: <20180707.201116.1526423963748651833.davem@davemloft.net>
References: <20180610231912.1543-1-3chas3@gmail.com>
        <20180702223528.582-1-3chas3@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: 3chas3@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:51338 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751863AbeGGLLS (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 7 Jul 2018 07:11:18 -0400
In-Reply-To: <20180702223528.582-1-3chas3@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Chas Williams <3chas3@gmail.com>
Date: Mon,  2 Jul 2018 18:35:28 -0400

> vlan_changelink silently ignores attempts to change the vlan id
> or protocol id of an existing vlan interface.  Implement by adding
> the new vlan id and protocol to the interface's vlan group and then
> removing the old vlan id and protocol from the vlan group.  This
> avoids the netlink churn of deleting and re-adding an interface
> to change the vlan id.
> 
> Signed-off-by: Chas Williams <3chas3@gmail.com>

Chas, it seems to me that you add the new notifier by not even one
driver is listening for the event.

Either it is necessary, and you should show at least one example
use case, or it not necessary and therefore should not be added.