From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, jbenc@redhat.com,
mike.rapoport@ravellosystems.com, stephen@networkplumber.org
Subject: Re: [PATCH net-next 0/4] vxlan: fix default fdb entry user-space notify ordering/race
Date: Sat, 07 Jul 2018 20:23:04 +0900 (KST) [thread overview]
Message-ID: <20180707.202304.545097069909614694.davem@davemloft.net> (raw)
In-Reply-To: <1530747992-15878-1-git-send-email-roopa@cumulusnetworks.com>
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Wed, 4 Jul 2018 16:46:28 -0700
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Problem:
> In vxlan_newlink, a default fdb entry is added before register_netdev.
> The default fdb creation function notifies user-space of the
> fdb entry on the vxlan device which user-space does not know about yet.
> (RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex).
>
> This series fixes the user-space netlink notification ordering issue
> with the following changes:
> - decouple fdb notify from fdb create.
> - Move fdb notify after register_netdev.
> - modify rtnl_configure_link to allow configuring a link early.
> - Call rtnl_configure_link in vxlan newlink handler to notify
> userspace about the newlink before fdb notify and
> hence avoiding the user-space race.
>
> Fixes: afbd8bae9c79 ("vxlan: add implicit fdb entry for default destination")
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
This is quite an old bug (circa v3.11). Maybe after this cooks for some
time in net-next you can also submit it for 'net' and we can thus send
it off to -stable as well?
Applied to net-next, thanks.
next prev parent reply other threads:[~2018-07-07 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 23:46 [PATCH net-next 0/4] vxlan: fix default fdb entry user-space notify ordering/race Roopa Prabhu
2018-07-04 23:46 ` [PATCH net-next 1/4] rtnetlink: add rtnl_link_state check in rtnl_configure_link Roopa Prabhu
2018-07-04 23:46 ` [PATCH net-next 2/4] vxlan: add new fdb alloc and create helpers Roopa Prabhu
2018-07-04 23:46 ` [PATCH net-next 3/4] vxlan: make netlink notify in vxlan_fdb_destroy optional Roopa Prabhu
2018-07-04 23:46 ` [PATCH net-next 4/4] vxlan: fix default fdb entry netlink notify ordering during netdev create Roopa Prabhu
2018-07-07 11:23 ` David Miller [this message]
2018-07-07 16:38 ` [PATCH net-next 0/4] vxlan: fix default fdb entry user-space notify ordering/race Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180707.202304.545097069909614694.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=mike.rapoport@ravellosystems.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox