From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 net-next 0/5] Introduce matching on double vlan/QinQ headers for TC flower Date: Sat, 07 Jul 2018 20:52:11 +0900 (KST) Message-ID: <20180707.205211.526234417742056887.davem@davemloft.net> References: <20180706053817.17712-1-jianbol@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jiri@resnulli.us To: jianbol@mellanox.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:52130 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753687AbeGGLwO (ORCPT ); Sat, 7 Jul 2018 07:52:14 -0400 In-Reply-To: <20180706053817.17712-1-jianbol@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jianbo Liu Date: Fri, 6 Jul 2018 05:38:11 +0000 > Currently TC flower supports only one vlan tag, it doesn't match on both outer > and inner vlan headers for QinQ. To do this, we add support to get both outer > and inner vlan headers for flow dissector, and then TC flower do matching on > those information. > > We also plan to extend TC command to support this feature. We add new > cvlan_id/cvlan_prio/cvlan_ethtype keywords for inner vlan header. The existing > vlan_id/vlan_prio/vlan_ethtype are for outer vlan header, and vlan_ethtype must > be 802.1q or 802.1ad. > > The examples for command and output are as the following. > # tc filter add dev ens1f1 parent ffff: protocol 802.1ad pref 33 \ > flower vlan_id 1000 vlan_ethtype 802.1q \ > cvlan_id 100 cvlan_ethtype ipv4 \ > action vlan pop \ > action vlan pop \ > action mirred egress redirect dev ens1f1_0 > > # tc filter show dev ens1f1 ingress > filter protocol 802.1ad pref 33 flower chain 0 > filter protocol 802.1ad pref 33 flower chain 0 handle 0x1 > vlan_id 1000 > vlan_ethtype 802.1Q > cvlan_id 100 > cvlan_ethtype ip > eth_type ipv4 > in_hw > ... > > v2: > fix sparse warning. Series applied, thank you.